Fix titleTemplate bug with multiple title children components #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 9, 2018 12:19
Regexp replacement with a function will call .toString() on the replacement candidate. That would include extra commas in page titles where the <title> component had multiple children.
Codecov Report
@@ Coverage Diff @@
## master #351 +/- ##
=========================================
+ Coverage 97.59% 97.6% +<.01%
=========================================
Files 3 3
Lines 291 292 +1
=========================================
+ Hits 284 285 +1
Misses 7 7
Continue to review full report at Codecov.
|
|
Looks good to me @joshgummersall ! |
vcarl
added a commit
to vcarl/react-helmet
that referenced
this pull request
May 21, 2019
vcarl
added a commit
to vcarl/react-helmet
that referenced
this pull request
May 21, 2019
vcarl
added a commit
to vcarl/react-helmet
that referenced
this pull request
May 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered a bug when using
titleTemplatewith a component that essentially renders a<title>with multiple child components (see the test case for an accurate simulation of this use case). This pull request fixes that behavior by callinginnermostTitle.join('')when doing the template replacement forinnermostTitles that are arrays.