Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

join_coalesce check for uniqueness should remove incomparables #234

Open
tanho63 opened this issue Mar 10, 2024 · 1 comment
Open

join_coalesce check for uniqueness should remove incomparables #234

tanho63 opened this issue Mar 10, 2024 · 1 comment

Comments

@tanho63
Copy link
Member

tanho63 commented Mar 10, 2024

Warning message:
Join `by` keys in x are not unique
Join `by` keys in y are not unique
Join `by` keys in x have NAs 

can be thrown if both sides have multiple NAs, should only apply NA warning

@tanho63
Copy link
Member Author

tanho63 commented Mar 27, 2024

join_coalesce is just much better with dplyr, should probably move to a different nflverse-utils pkg tbh.

https://github.com/tanho63/tantastic/blob/main/R/coalesce_join.R

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant