Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

load PFR #17

Merged
merged 18 commits into from
Aug 6, 2021
Merged

load PFR #17

merged 18 commits into from
Aug 6, 2021

Conversation

guga31bb
Copy link
Member

@guga31bb guga31bb commented Aug 5, 2021

Not ready. Still need documentation and snap counts

@guga31bb guga31bb changed the title initial commit load PFR Aug 5, 2021
@guga31bb guga31bb marked this pull request as draft August 6, 2021 00:38
@guga31bb
Copy link
Member Author

guga31bb commented Aug 6, 2021

Why is this failing now...

@guga31bb
Copy link
Member Author

guga31bb commented Aug 6, 2021 •
edited

  • Wait for Lee to add .rds for draft picks
  • Data dictionaries
  • Tests?

@guga31bb guga31bb marked this pull request as ready for review August 6, 2021 15:37
@guga31bb guga31bb requested a review from mrcaseb August 6, 2021 15:40
@tanho63 tanho63 mentioned this pull request Aug 6, 2021
Closed
22 tasks
mrcaseb
mrcaseb reviewed Aug 6, 2021
View reviewed changes
R/load_nflverse.R Outdated Show resolved Hide resolved
@guga31bb
Copy link
Member Author

guga31bb commented Aug 6, 2021

OKAY this might be finally ready?

mrcaseb
mrcaseb reviewed Aug 6, 2021
View reviewed changes
R/load_nflverse.R Outdated Show resolved Hide resolved
@mrcaseb
Copy link
Member

mrcaseb commented Aug 6, 2021

Sorry @guga31bb one last request:
Could you add lines to your tests for passing and snap counts where you let it error with a character input like here?

@guga31bb
Copy link
Member Author

guga31bb commented Aug 6, 2021

Sorry @guga31bb one last request:
Could you add lines to your tests for passing and snap counts where you let it error with a character input like here?

Done!

@mrcaseb
Copy link
Member

mrcaseb commented Aug 6, 2021

Looks good to me now! Any objections @tanho63?

@tanho63
Copy link
Member

tanho63 commented Aug 6, 2021

Yep LGTM

@tanho63 tanho63 merged commit b7d4412 into main Aug 6, 2021
@tanho63 tanho63 deleted the load_pfr branch August 6, 2021 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrcaseb mrcaseb mrcaseb left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@guga31bb @mrcaseb @tanho63