Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add load_espn_qbr() #19

Merged
merged 8 commits into from
Aug 6, 2021
Merged

add load_espn_qbr() #19

merged 8 commits into from
Aug 6, 2021

Conversation

tanho63
Copy link
Member

@tanho63 tanho63 commented Aug 6, 2021

No description provided.

@tanho63 tanho63 mentioned this pull request Aug 6, 2021
Closed
22 tasks
@tanho63 tanho63 requested a review from mrcaseb August 6, 2021 12:44
mrcaseb
mrcaseb approved these changes Aug 6, 2021
View reviewed changes
Copy link
Member

@mrcaseb mrcaseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also looks good to me. I am wondering if we should just wait until Tom adds rds or qs files instead of loading the csvs?

@tanho63
Copy link
Member Author

tanho63 commented Aug 6, 2021

yeah, happy to let this PR sit til then

@tanho63
Copy link
Member Author

tanho63 commented Aug 6, 2021

(the slightest possible nudge @jthomasmock)

@tanho63 tanho63 enabled auto-merge August 6, 2021 20:20
@tanho63 tanho63 merged commit ead6180 into main Aug 6, 2021
@tanho63 tanho63 deleted the espn-qbr branch August 6, 2021 20:26
@jthomasmock
Copy link

RDS has been added and will try to add qs with the GHA automation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrcaseb mrcaseb mrcaseb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tanho63 @jthomasmock @mrcaseb