Performance and message cleanup #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is a big speed bump because dplyr bind_rows is slow at binding lists and data.table is a reverse dependency anyways
we need data.table for quick list binding and can use it to replace csv download with readr
and games data attributes modification for consistency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will
heavily improve performance of
simulate_nfl(), esp. the part where simulation data are combined. This imrpoved data combining runtime of a 50k simulation from 168 seconds to 8 seconds.add nflseedR version and simulation finish time to sims params
drop readr dependency and add data.table dependency
improve messaging by making the full transition to cli.
drop curl, crayon, and glue dependencies