Clarify weeks in depth charts

[mrcaseb]

This problem has been discussed here first nflverse/nflreadr#78

I wrote some code to look at this and I think its a bit inconsistent

• week 18 is missing for <2006
• postseason is missing for 2005
• SB is week 22 for 2004, 2006, 2014
• week 20 mostly > week 19

library(dplyr, warn.conflicts = FALSE)
library(ggplot2)

df <- nflreadr::load_depth_charts(TRUE)

df |> 
  group_by(season, week, team) |> 
  summarise() |> 
  ungroup() |> 
  count(season, week) |> 
  mutate(alpha = ifelse(n == 32, 0.2, 1)) |> 
  ggplot(aes(x = season, y = week)) +
  geom_text(aes(label = n, alpha = alpha), size = 3) +
  scale_alpha_identity() +
  scale_y_continuous(breaks = scales::breaks_pretty(n = 10)) +
  theme_minimal()

[mrcaseb]

We need to clarify season_type and week.
Somewhere here?
https://github.com/nflverse/nflfastR-roster/blob/98e9d5283062138bc7806c49f495f2a10a90abc2/src/update-depth-charts.R#L73-L74

[john-b-edwards]

Me unmasking who wrote the code that caused this issue in the first place:

[tanho63]

I think that looks better but we'll see when it runs a few more

[john-b-edwards]

Will try to hit this tonight or tomorrow and make sure this is 100% fixed