Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New roster work #37

Merged
merged 10 commits into from
Aug 1, 2022
Merged

New roster work #37

merged 10 commits into from
Aug 1, 2022

Conversation

john-b-edwards
Copy link
Contributor

Would appreciate a particularly close look at the code / data objects produced and saved here, haven't run anything to avoid overwriting existing objects

@john-b-edwards
wip roster dev
bbe7655
@john-b-edwards
in progress roster work
a1e50cc
@john-b-edwards
weekly roster update code
639a4a1 
would appreciate some very close inspection of this code/resulting data objects before we merge
@john-b-edwards
Update update-weekly-rosters.R
be51874
tanho63
tanho63 reviewed Jul 10, 2022
View reviewed changes
src/update-roster-new.R Outdated Show resolved Hide resolved
tanho63
tanho63 reviewed Jul 10, 2022
View reviewed changes
src/update-roster-new.R Outdated Show resolved Hide resolved
tanho63
tanho63 reviewed Jul 10, 2022
View reviewed changes
src/update-roster-new.R Outdated Show resolved Hide resolved
tanho63
tanho63 reviewed Jul 10, 2022
View reviewed changes
Copy link
Member

@tanho63 tanho63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding some mostly-higher level commentary on things I know a bit better. I recognize a lot of @mrcaseb code from previous rosters here so perhaps leaving it to him for now - I'll try and check out the PR later this week/end otherwise.

@john-b-edwards
Copy link
Contributor Author

Sorry for the confusion, update-roster-new.R was a WIP file that I shouldn't have comitted. update-weekly-rosters.R is the real workhorse and does everything update-roster-new.R does and then some, using the NGS API for 2016 on, using the data exchange API for 2002-2015, and using the sleeper API for 1999-2001.

mrcaseb
mrcaseb reviewed Aug 1, 2022
View reviewed changes
Copy link
Member

@mrcaseb mrcaseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor things

.github/workflows/update_weekly_rosters.yaml Show resolved Hide resolved
src/update_roster.R Outdated Show resolved Hide resolved
src/update_roster.R Outdated Show resolved Hide resolved
mrcaseb
mrcaseb approved these changes Aug 1, 2022
View reviewed changes
Copy link
Member

@mrcaseb mrcaseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go with this. I can't thank you enough, John!

@mrcaseb mrcaseb merged commit dd3a16f into nflverse:master Aug 1, 2022
@john-b-edwards john-b-edwards deleted the new-roster-work branch August 1, 2022 15:43
tanho63 pushed a commit that referenced this pull request Aug 9, 2022
@mrcaseb
Merge pull request #37 from john-b-edwards/new-roster-work
6929f17 
New roster work
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanho63 tanho63 tanho63 left review comments

@mrcaseb mrcaseb mrcaseb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@john-b-edwards @tanho63 @mrcaseb