-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New roster work #37
New roster work #37
Conversation
would appreciate some very close inspection of this code/resulting data objects before we merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding some mostly-higher level commentary on things I know a bit better. I recognize a lot of @mrcaseb code from previous rosters here so perhaps leaving it to him for now - I'll try and check out the PR later this week/end otherwise.
removing commit/pull stuff
quick fixes
Sorry for the confusion, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor things
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go with this. I can't thank you enough, John!
Would appreciate a particularly close look at the code / data objects produced and saved here, haven't run anything to avoid overwriting existing objects