Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Filenames with dashes instead of spaces #4

Merged
merged 3 commits into from
Dec 11, 2012
Merged

Support Filenames with dashes instead of spaces #4

merged 3 commits into from
Dec 11, 2012

Conversation

torandu
Copy link
Contributor

@torandu torandu commented Dec 11, 2012

Hello. I had a requirement to support files on disk that use dashes instead of spaces. I added a config option :filenames_use_dashes_instead_of_spaces. The option is set to false by default, so old behavior is unchanged. One note: I instinctively used symbols for option keys --might be a better way to go, although the change requires a change to ~/.zenpush.yml. I updated the README to reflect the change.

- Add option: filenames_use_dashes_instead_of_spaces
  - Support paths and file names that use dashes instead of spaces
  - Continue to use spaces for Zendesk API calls (Category, Forum, and
    Entry names)
- Support .markdown and make it case insensitive (was a TODO item)
- Use symbols in ~/.zenpush.yml
- Make sure we can read ~/.zenpush.yml before merging options
- Raise an error if uri, user, or password is nil
nfo added a commit that referenced this pull request Dec 11, 2012
Support Filenames with dashes instead of spaces, symbols in .zenpush.yml.
@nfo nfo merged commit 613f52f into nfo:master Dec 11, 2012
@nfo
Copy link
Owner

nfo commented Dec 11, 2012

Thanks! Pushing a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants