Bug AOEpeople#4, Accessibility fix - CSS font-size in 'rem', not 'px'

nfreear · Jun 3, 2018 · 9979c4f · 9979c4f
1 parent 59269f6
commit 9979c4f
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/cookie.notice.js b/src/cookie.notice.js
@@ -42,7 +42,7 @@
         },
 
         'expiresIn': 30,
-        'buttonBgColor': '#983c00', // Accessibility contrast fix (Was: '#d35400').
+        'buttonBgColor': '#ca5000', // Accessibility contrast fix (Was: '#d35400') (WCAG2AAA: '#983c00').
         'buttonTextColor': '#fff',
         'noticeBgColor': '#000',
         'noticeTextColor': '#fff',
@@ -166,7 +166,7 @@
 
         var notice = document.createElement('div'),
             noticeStyle = notice.style,
-            lineHeight = 28,
+            lineHeight = 2, // Was: 28 (px).
             paddingBottomTop = 10,
             fontSize = lineHeight / 2.333,
             noticeHeight = lineHeight + paddingBottomTop * 2;
@@ -198,8 +198,8 @@
         noticeStyle["z-index"] = '999';
         noticeStyle.padding = paddingBottomTop + 'px 5px';
         noticeStyle["text-align"] = 'center';
-        noticeStyle["font-size"] = fontSize + "px";
-        noticeStyle["line-height"] = lineHeight + "px";
+        noticeStyle["font-size"] = fontSize + 'rem'; // Was: 'px'.
+        noticeStyle["line-height"] = lineHeight + 'rem'; // Was: 'px'.
         noticeStyle.fontFamily = 'Helvetica neue, Helvetica, sans-serif';