forked from micc83/cookie-notice-js
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'data-cookie-notice' HTML attribute, other suggestions / wishlist #4
Comments
nfreear
added a commit
to nfreear/cookie-notice
that referenced
this issue
May 30, 2018
nfreear
added a commit
to nfreear/cookie-notice
that referenced
this issue
May 30, 2018
…EADME * Plus, switch npm badge to ~ https://badge.fury.io/
nfreear
added a commit
to nfreear/cookie-notice
that referenced
this issue
Jun 2, 2018
… [ci skip] * Add `files`, bugs, engines & contributors fields to package JSON; * Remove Nick's email address from README & bower JSON; * Validator ~ http://package-json-validator.com/
nfreear
added a commit
to nfreear/cookie-notice
that referenced
this issue
Jun 2, 2018
nfreear
added a commit
to nfreear/cookie-notice
that referenced
this issue
Jun 3, 2018
….0 AAA * Automated accessibility testing via ~ http://pa11y.org/
nfreear
added a commit
to nfreear/cookie-notice
that referenced
this issue
Jun 3, 2018
* ... plus - link target, link underline
nfreear
added a commit
to nfreear/cookie-notice
that referenced
this issue
Jun 3, 2018
nfreear
added a commit
to nfreear/cookie-notice
that referenced
this issue
Jun 3, 2018
…CAG2AA * ... in the Grunt Javascript * Plus, add `live-server` to `peerDependencies` package JSON
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
I've got some suggestions for improvements that I hope will benefit most users ... I'll create pull requests as I work through some of these.
Proposed changes / "wishlist"
Allow configuration options to be set via JSON in a, pull Add support fordata-cookie-notice
HTML attribute on a<script>
elementdata-cookie-attribute
#5;Add Travis-CI build and test (qunit etc.), pull Add Travis-CI automated tests #1, Follow-up to pull #1 - move jQuery todevDependencies
for clarity #2;semistandard
/ ESLint-type tests — Flet/semistandard;style
attribute to<style>
element, or separate stylesheet — create<style>
or<link>
via the Javascript — make it easier to override styles;Aims
While working on the proposed fixes, the aim is to:
See notes on Google Docs.
Example HTML
Here is an example of using the proposed
data-cookie-notice
attribute:The text was updated successfully, but these errors were encountered: