Update dependencies #147
Closed
Update dependencies #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XhmikosR
commented
Mar 17, 2022
package.json
Outdated
| "metapak": "^4.0.2", | ||
| "metapak-nfroidure": "^11.0.7", | ||
| "mocha": "^8.3.2", | ||
| "metapak-nfroidure": "^11.1.1", |
There was a problem hiding this comment.
@nfroidure BTW this is incompatible with metapak 4.x, unsure if it's still used or not, but I've already made an upstream PR to allow metapak 4.x too. nfroidure/metapak-nfroidure#28
XhmikosR
commented
Mar 18, 2022
| @@ -49,22 +49,22 @@ | |||
| }, | |||
| "dependencies": { | |||
| "commander": "^7.2.0", | |||
| "glob": "^7.1.6", | |||
| "glob": "^7.2.0", | |||
| "sax": "^1.2.4", | |||
There was a problem hiding this comment.
Might be worth switching to @trysound/sax later which is what svgo is using.
|
Closing in favor of: #156 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These should be compatible with Node.js >= 12.
Requires #145
Fixes #
Proposed changes
Code quality
contributors
field of the package.json file
License
To get your contribution merged, you must check the following.
Join
My NPM username: