Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getrlimit fixes + logging fixes + various minor #1

Closed
wants to merge 11 commits into from
Closed

getrlimit fixes + logging fixes + various minor #1

wants to merge 11 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Dec 1, 2012

No description provided.

@ExaTad ExaTad mentioned this pull request May 22, 2014
Closed
@jbreitbart jbreitbart mentioned this pull request Mar 16, 2015
Closed
@ovjh ovjh mentioned this pull request May 2, 2015
Closed
@ffilz ffilz closed this Jan 19, 2016
malahal referenced this pull request in malahal/nfs-ganesha Jun 3, 2016
Close cached target file descriptor in RENAME operation.
617ee6f 
RENAME operation has an implicit remove if the target already exists.
Close the target file if it was opened for caching purposes.

Change-Id: I1951e38608feae766674f3ee5060b38f89f898ba
Signed-off-by: Malahal Naineni <malahal@us.ibm.com>
@tm4n tm4n mentioned this pull request Feb 28, 2017
Closed
@apnorrie apnorrie mentioned this pull request Apr 28, 2017
Closed
@rmu75 rmu75 mentioned this pull request May 15, 2017
Closed
madhuthorat pushed a commit to madhuthorat/nfs-ganesha that referenced this pull request May 25, 2017
@mattbenjamin
Fix svc_init() to unlock upon returning a failure
c952faf 
Coverity CID 130080 (nfs-ganesha#1 of 1): Missing unlock (LOCK)

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
ffilz pushed a commit that referenced this pull request Nov 10, 2017
@ffilz
9P lock: aquire state_lock properly
3b857f1 
The caller of state_lock() is expected to take the lock on its own.
This should fix the sporadical failure seen in this patchset:
https://review.gerrithub.io/#/c/385433/

==3884==ERROR: AddressSanitizer: heap-use-after-free on address 0x6110003fbf68 at pc 0x00000077cd18 bp 0x7fffc9cbf150 sp 0x7fffc9cbf148
READ of size 8 at 0x6110003fbf68 thread T34
Detaching after fork from child process 3944.
    #0 0x77cd17 in copy_conflict /export/nfs-ganesha/src/SAL/state_lock.c:2239:26
    #1 0x77fa9c in state_lock /export/nfs-ganesha/src/SAL/state_lock.c:2444:5
    #2 0x733404 in _9p_lock /export/nfs-ganesha/src/Protocols/9P/9p_lock.c:168:18
    #3 0x71c904 in _9p_process_buffer /export/nfs-ganesha/src/Protocols/9P/9p_interpreter.c:180:7
    #4 0x5fb386 in _9p_rdma_process_request /export/nfs-ganesha/src/MainNFSD/9p_rdma_callbacks.c:158:8
    #5 0x5c928f in _9p_execute /export/nfs-ganesha/src/MainNFSD/nfs_worker_thread.c:1509:3
    #6 0x5aa899 in worker_run /export/nfs-ganesha/src/MainNFSD/nfs_worker_thread.c:1604:4
    #7 0x88c1c4 in fridgethr_start_routine /export/nfs-ganesha/src/support/fridgethr.c:550:3
    #8 0x7ffff79b16c9 in start_thread (/lib64/libpthread.so.0+0x76c9)
    #9 0x7ffff4ed7f7e in __GI___clone (/lib64/libc.so.6+0x107f7e)

0x6110003fbf68 is located 104 bytes inside of 200-byte region [0x6110003fbf00,0x6110003fbfc8)
freed by thread T26 here:
    #0 0x4e2ae0 in __interceptor_cfree.localalias.1 (/export/nfs-ganesha/build/MainNFSD/ganesha.nfsd+0x4e2ae0)
    #1 0x7731e4 in gsh_free /export/nfs-ganesha/src/include/abstract_mem.h:271:2
    #2 0x7731b6 in lock_entry_dec_ref /export/nfs-ganesha/src/SAL/state_lock.c:714:3
    #3 0x77b06a in remove_from_locklist /export/nfs-ganesha/src/SAL/state_lock.c:774:2
    #4 0x78d39a in free_list /export/nfs-ganesha/src/SAL/state_lock.c:967:3
    #5 0x7848c4 in subtract_lock_from_list /export/nfs-ganesha/src/SAL/state_lock.c:1140:3
    #6 0x7833ac in state_unlock /export/nfs-ganesha/src/SAL/state_lock.c:2716:11
    #7 0x7334fe in _9p_lock /export/nfs-ganesha/src/Protocols/9P/9p_lock.c:187:7
    #8 0x71c904 in _9p_process_buffer /export/nfs-ganesha/src/Protocols/9P/9p_interpreter.c:180:7
    #9 0x5fb386 in _9p_rdma_process_request /export/nfs-ganesha/src/MainNFSD/9p_rdma_callbacks.c:158:8
    #10 0x5c928f in _9p_execute /export/nfs-ganesha/src/MainNFSD/nfs_worker_thread.c:1509:3
    #11 0x5aa899 in worker_run /export/nfs-ganesha/src/MainNFSD/nfs_worker_thread.c:1604:4
    #12 0x88c1c4 in fridgethr_start_routine /export/nfs-ganesha/src/support/fridgethr.c:550:3
    #13 0x7ffff79b16c9 in start_thread (/lib64/libpthread.so.0+0x76c9)

previously allocated by thread T16 here:
    #0 0x4e2c98 in __interceptor_malloc (/export/nfs-ganesha/build/MainNFSD/ganesha.nfsd+0x4e2c98)
    #1 0x77443f in gsh_malloc__ /export/nfs-ganesha/src/include/abstract_mem.h:78:12
    #2 0x780f13 in create_state_lock_entry /export/nfs-ganesha/src/SAL/state_lock.c:579:14
    #3 0x77ffcf in state_lock /export/nfs-ganesha/src/SAL/state_lock.c:2562:16
    #4 0x733404 in _9p_lock /export/nfs-ganesha/src/Protocols/9P/9p_lock.c:168:18
    #5 0x71c904 in _9p_process_buffer /export/nfs-ganesha/src/Protocols/9P/9p_interpreter.c:180:7
    #6 0x5fb386 in _9p_rdma_process_request /export/nfs-ganesha/src/MainNFSD/9p_rdma_callbacks.c:158:8
    #7 0x5c928f in _9p_execute /export/nfs-ganesha/src/MainNFSD/nfs_worker_thread.c:1509:3
    #8 0x5aa899 in worker_run /export/nfs-ganesha/src/MainNFSD/nfs_worker_thread.c:1604:4
    #9 0x88c1c4 in fridgethr_start_routine /export/nfs-ganesha/src/support/fridgethr.c:550:3
    #10 0x7ffff79b16c9 in start_thread (/lib64/libpthread.so.0+0x76c9)

Thanks goes to Malahal for the analysis of the problem

Change-Id: Ie82eb4a5ecf5da3fd3a8d1cd9dbdb99b54842745
Signed-off-by: Dominique Martinet <dominique.martinet@cea.fr>
@malahal malahal mentioned this pull request Jan 15, 2018
Closed
@JoelStienlet JoelStienlet mentioned this pull request May 26, 2018
Closed
@stuarthu stuarthu mentioned this pull request Jul 4, 2018
Closed
@supriti supriti mentioned this pull request Jul 23, 2018
Closed
@diederichm diederichm mentioned this pull request Aug 14, 2018
Closed
@shangzhong shangzhong mentioned this pull request Sep 4, 2018
Closed
@rafalop rafalop mentioned this pull request Oct 23, 2020
Closed
@malahal malahal mentioned this pull request Oct 26, 2020
Closed
@FANGXIANGQUAN FANGXIANGQUAN mentioned this pull request Sep 1, 2021
Closed
@dang dang mentioned this pull request Sep 3, 2021
Closed
@dgengtek dgengtek mentioned this pull request Mar 9, 2022
Open
@twoholes twoholes mentioned this pull request Apr 2, 2022
Closed
@skmprabhu1 skmprabhu1 mentioned this pull request Jun 7, 2022
Closed
@alvic2000 alvic2000 mentioned this pull request Jun 10, 2022
Closed
@hnkboy hnkboy mentioned this pull request Mar 13, 2023
Closed
@skmprabhu skmprabhu mentioned this pull request Apr 4, 2023
Closed
@kalebskeithley kalebskeithley mentioned this pull request Jun 5, 2023
Open
@skmprabhu252 skmprabhu252 mentioned this pull request Jun 16, 2023
Closed
@bear-Zhao178 bear-Zhao178 mentioned this pull request Jul 15, 2023
Open
This was referenced Jul 17, 2023
Closed
Closed
@bjfhdhhaha bjfhdhhaha mentioned this pull request Aug 21, 2023
Closed
@dhowells dhowells mentioned this pull request Dec 20, 2023
Open
@tianyangfengbyte tianyangfengbyte mentioned this pull request Jan 7, 2024
Open
@bear-Zhao178 bear-Zhao178 mentioned this pull request Jan 20, 2024
Closed
@skmprabhu252 skmprabhu252 mentioned this pull request Jan 23, 2024
Closed
This was referenced Jan 24, 2024
Open
Open
Open
Open
@skmprabhu252 skmprabhu252 mentioned this pull request Feb 19, 2024
Open
ffilz pushed a commit that referenced this pull request Feb 22, 2024
@xueqianhu47 @ffilz
Enable libunwind in ganesha
158f395 
Currently, Ganesha uses backtrace during crashes,
which may not provide sufficient useful information:
07/02/2024 19:09:18: epoch 65c3d55b: xueqian-hu: nfs-ganesha-39008[main] gsh_backtrace: NFS STARTUP: MAJ: stack
backtrace follows:
/lib64/libganesha_nfsd.so.5.6(+0x83ba1)[0x7f64d9172ba1]
/lib64/libganesha_nfsd.so.5.6(+0x5d618)[0x7f64d914c618]
/lib64/libpthread.so.0(+0xf630)[0x7f64d7d1a630]
/lib64/libpthread.so.0(pthread_join+0xa7)[0x7f64d7d14017]
/lib64/libganesha_nfsd.so.5.6(nfs_start+0x323)[0x7f64d914eff3]
ganesha.nfsd(main+0xbef)[0x4025cf]
/lib64/libc.so.6(__libc_start_main+0xf5)[0x7f64d753d555]
ganesha.nfsd[0x402663]

This patch introduces an option to use libunwind, which can display function information:
08/02/2024 20:06:04: epoch 65c53429: xueqian-hu: nfs-ganesha-99814[main] gsh_libunwind: NFS STARTUP: MAJ: BACKTRACE:
08/02/2024 20:06:04 : epoch 65c53429 : xueqian-hu : nfs-ganesha-99814[main] gsh_libunwind :NFS STARTUP :MAJ :BACKTRACE:
 #0 gsh_libunwind + 0x29 [ip=0x7f90b1a10859] [sp=0x7ffd49d53c00]
 #1 crash_handler + 0x8 [ip=0x7f90b19e9fd8] [sp=0x7ffd49d54670]
 #2 _L_unlock_13 + 0x34 [ip=0x7f90b039d630] [sp=0x7ffd49d54680]
 #3 pthread_join + 0xa7 [ip=0x7f90b0397017] [sp=0x7ffd49d55380]
 #4 nfs_start + 0x323 [ip=0x7f90b19ec9b3] [sp=0x7ffd49d553e0]
 #5 main + 0xbef [ip=0x4025df] [sp=0x7ffd49d55480]

Change-Id: I194853e25ec0c89c7f552dc4872c37a420ea8d4a
Signed-off-by: Xueqian Hu <xh140312@outlook.com>
@JYang1986 JYang1986 mentioned this pull request Mar 21, 2024
Closed
@yogendra-t yogendra-t mentioned this pull request Mar 25, 2024
Open
zhitaoli-6 pushed a commit to zhitaoli-6/nfs-ganesha that referenced this pull request Mar 25, 2024
@hpingfs
Merge pull request nfs-ganesha#1 from iomesh/dev/v4-recovery-backend
227558e 
feat: introduce sfs cluster recovery backend
@Haroldll Haroldll mentioned this pull request Mar 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ffilz @paulsheer