Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add cidv0 example #991

Merged
merged 2 commits into from
Jan 5, 2022
Merged

docs: add cidv0 example #991

merged 2 commits into from
Jan 5, 2022

Conversation

alanshaw
Copy link
Contributor

ipfs-car@0.6.1 now supports the rawLeaves option.

It means that if absolutely necessary, a v0 CID can be obtained for a DAG by downgrading the CID returned from the library (note this is only possible by using rawLeaves: false).

How far do we want to go with this? We could stop here, or we could add it as an option to the client that encodeDirectory and encodeBlob might take - the example becomes simplier but we'll need to release a new version of the client. My gut instinct is to leave it like this.

@alanshaw alanshaw changed the title Docs/cidv0 example docs: add cidv0 example Dec 16, 2021
@cloudflare-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: e933e5c
Status: ✅  Deploy successful!
Preview URL: https://cf5346d3.nft-storage-1at.pages.dev

View logs

@dchoi27 dchoi27 mentioned this pull request Jan 4, 2022
@dchoi27
Copy link
Contributor

dchoi27 commented Jan 4, 2022

@alanshaw should we merge this?

Copy link
Contributor

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants