Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wasm module loading #176

Merged
merged 4 commits into from
Aug 30, 2022
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/edge-gateway/src/gateway.js
Original file line number Diff line number Diff line change
Expand Up @@ -537,7 +537,7 @@ function getTransformedResponseWithCustomHeaders(response) {

clonedResponse.headers.set(
'content-security-policy',
"default-src 'self' 'unsafe-inline' blob: data: ; form-action 'self' ; navigate-to 'self' "
"default-src 'self' 'unsafe-inline' 'unsafe-eval' blob: data: ; form-action 'self' ; navigate-to 'self' "
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have considered this in #172 (comment), but left it out. As it turns out leaving it out prevents WASM module loading which is not a desired behavior.

We could enable just wasm via unsafe-wasm-eval directive, however I don't see a good reason to disable js eval so I'm proposing this.

Gozala marked this conversation as resolved.
Show resolved Hide resolved
)

return clonedResponse
Expand Down