Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(abc:st): fix invalid toTop when scroll is set #1311

Merged
merged 3 commits into from
Aug 9, 2021
Merged

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Aug 8, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Aug 8, 2021

Codecov Report

Merging #1311 (538f882) into master (4ef5a59) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1311      +/-   ##
==========================================
- Coverage   95.88%   95.88%   -0.01%     
==========================================
  Files         269      269              
  Lines        8269     8268       -1     
  Branches     1502     1502              
==========================================
- Hits         7929     7928       -1     
  Misses        157      157              
  Partials      183      183              
Impacted Files Coverage Δ
packages/abc/st/st.component.ts 99.55% <100.00%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ef5a59...538f882. Read the comment docs.

@ng-alain-bot
Copy link
Contributor

ng-alain-bot commented Aug 8, 2021

Preview is ready!

@cipchk cipchk merged commit c07e1fa into master Aug 9, 2021
@cipchk cipchk deleted the issues-2056 branch August 9, 2021 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When use ST Scroll, STPage toTop not working
2 participants