Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(abc:reuse-tab): refactor reuse tab #863

Merged
merged 8 commits into from May 1, 2020
Merged

refactor(abc:reuse-tab): refactor reuse tab #863

merged 8 commits into from May 1, 2020

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Apr 29, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@cipchk
Copy link
Member Author

cipchk commented Apr 29, 2020

Preview is ready!

@codecov
Copy link

codecov bot commented Apr 29, 2020

Codecov Report

Merging #863 into master will decrease coverage by 0.06%.
The diff coverage is 94.04%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #863      +/-   ##
==========================================
- Coverage   97.48%   97.42%   -0.07%     
==========================================
  Files         233      233              
  Lines        6922     6951      +29     
  Branches     1317     1319       +2     
==========================================
+ Hits         6748     6772      +24     
  Misses        117      117              
- Partials       57       62       +5     
Impacted Files Coverage Δ
packages/abc/reuse-tab/reuse-tab.interfaces.ts 100.00% <ø> (ø)
packages/abc/reuse-tab/reuse-tab.component.ts 96.62% <92.53%> (-3.38%) ⬇️
packages/abc/reuse-tab/reuse-tab.service.ts 100.00% <100.00%> (ø)
packages/form/src/widgets/select/select.widget.ts 78.43% <0.00%> (-0.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5009c5d...ba5fe42. Read the comment docs.

@cipchk cipchk changed the title fix(abc:reuse-tab): fix wrong scroll position refactor(abc:reuse-tab): refactor reuse tab Apr 30, 2020
@cipchk cipchk merged commit ea588b2 into master May 1, 2020
@cipchk cipchk deleted the dev-reuse-tab branch May 1, 2020 06:29
goten002 pushed a commit to goten002/delon that referenced this pull request May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant