Skip to content

Commit

Permalink
fix(typeahead): remove aria-multiline attribute (#4409)
Browse files Browse the repository at this point in the history
Removes `aria-multiline="false"`, which is invalid on comboboxes.

Fixes #4181
  • Loading branch information
stephanieleary committed Oct 26, 2022
1 parent 0366612 commit 9bd749c
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 2 deletions.
1 change: 0 additions & 1 deletion src/typeahead/typeahead.spec.ts
Expand Up @@ -796,7 +796,6 @@ describe('ngb-typeahead', () => {
fixture.detectChanges();

expect(input.getAttribute('role')).toBe('combobox');
expect(input.getAttribute('aria-multiline')).toBe('false');
expect(input.getAttribute('aria-autocomplete')).toBe('list');
expect(input.getAttribute('aria-expanded')).toBe('false');
expect(input.getAttribute('aria-owns')).toBeNull();
Expand Down
1 change: 0 additions & 1 deletion src/typeahead/typeahead.ts
Expand Up @@ -68,7 +68,6 @@ let nextWindowId = 0;
autocapitalize: 'off',
autocorrect: 'off',
role: 'combobox',
'aria-multiline': 'false',
'[attr.aria-autocomplete]': 'showHint ? "both" : "list"',
'[attr.aria-activedescendant]': 'activeDescendant',
'[attr.aria-owns]': 'isPopupOpen() ? popupId : null',
Expand Down

0 comments on commit 9bd749c

Please sign in to comment.