Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The aria-multiline attribute is invalid on combobox role #4181

Closed
atarix83 opened this issue Nov 10, 2021 · 1 comment · Fixed by #4409
Closed

The aria-multiline attribute is invalid on combobox role #4181

atarix83 opened this issue Nov 10, 2021 · 1 comment · Fixed by #4409
Labels
component: typeahead type: accessibility
Milestone
13.2.0

Comments

@atarix83
Copy link

Bug description:

When using the the typeahead component aria-multiline="false" is added to the input but is not allowed since is valid only for the textbox role while by using the typeahead component the role is combobox.
This is an accesibility issue because elements must only use allowed ARIA attributes.

Link to minimally-working StackBlitz that reproduces the issue:

https://stackblitz.com/run?file=app/typeahead-basic.ts

Versions of Angular, ng-bootstrap and Bootstrap:

Angular: 10.2.3

ng-bootstrap: 7.0.0

Bootstrap: 4.3.1
@atarix83 atarix83 mentioned this issue Nov 10, 2021
Open
stephanieleary added a commit to stephanieleary/ng-bootstrap that referenced this issue Oct 24, 2022
@stephanieleary
fix(typeahead): remove aria-multiline attribute
77ae4e7 
Removes `aria-multiline="false"`, which is invalid on comboboxes.

Fixes ng-bootstrap#4181
@stephanieleary stephanieleary mentioned this issue Oct 24, 2022
Merged
@maxokorokov
Copy link
Member

Indeed, I think the confusion was resolved with w3c/aria#1176

@maxokorokov maxokorokov added this to the 13.2.0 milestone Oct 25, 2022
maxokorokov pushed a commit that referenced this issue Oct 26, 2022
@stephanieleary
fix(typeahead): remove aria-multiline attribute (#4409)
9bd749c 
Removes `aria-multiline="false"`, which is invalid on comboboxes.

Fixes #4181
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: typeahead type: accessibility
Projects
None yet
Milestone
13.2.0
Development

Successfully merging a pull request may close this issue.

fix(typeahead): remove aria-multiline attribute stephanieleary/ng-bootstrap
3 participants
@pkozlowski-opensource @atarix83 @maxokorokov