chore: angular 4 upgrade #1415
chore: angular 4 upgrade #1415
Conversation
|
Hi! Thnx for the PR. We can't merge it just yet as it would mean dropping support for Angular 2.x and we don't want to do it just yet. See #1337 for more details. Having said this I'm going to keep this PR around so we know what / where to change when the update time comes. |
|
@pkozlowski-opensource Have you guys considered moving the v4 migration to a different branch and make both available through npm so that people can use it both on angular 2 and 4? As the Angular folks do it. |
| "target": "ES5", | ||
| "lib": ["es2015", "dom"], | ||
| "target": "es5", | ||
| "lib": ["es2016", "dom"], |
| "module": "commonjs", | ||
| "moduleResolution": "node", |
| require('zone.js/dist/proxy.js'); | ||
| require('zone.js/dist/sync-test'); | ||
| require('zone.js/dist/async-test'); | ||
| require('zone.js/dist/fake-async-test'); |
There was a problem hiding this comment.
I don't think we use those for unit tests so we shouldn't be having this change.
|
@willyelm thnx for the PR - I've just started to review it but there are many changes in there and many of those are not related to the Angular 4 switch... Given this (and the fact that this PR doesn't merge cleanly any more) I'm going to pick up bits and pieces but won't be able to land the whole PR. I will leave comments here indicating which commits I'm brining in. Once again, thnx for the PR. |
|
Hi @pkozlowski-opensource, Thanks! let me know if I can help. |
Commits picked up from #1415
|
Merged WebPack config changes as 6616c77 - it was possible to land those now since not related to Angular 4 switch. |
Commits picked up from ng-bootstrap/ng-bootstrap#1415
Before submitting a pull request, please make sure you have at least performed the following: