Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to Angular 4 #1439

Closed
7 tasks done
pkozlowski-opensource opened this issue Apr 5, 2017 · 10 comments
Closed
7 tasks done

Move to Angular 4 #1439

pkozlowski-opensource opened this issue Apr 5, 2017 · 10 comments

Comments

@pkozlowski-opensource
Copy link
Member

pkozlowski-opensource commented Apr 5, 2017

There are several things that need to happen in order to fully move to Angular 4 (note: we do support Angular 4 already, this issue just summarizes things that need to happen to fully drop support to Angular 2):

  • cut a bug fix release just before (so people still on Angular 2.x can update)
  • change all the references from <template> to <ng-template> in src code
  • change all the references from <template> to <ng-template> in docs
  • update generated package.json constraints
  • update versions in documentation (demo, README etc.)
  • update plunker templates to use just one variable for ng versions (instead a separate one for core and a different one for a router)
  • add breaking change section to the release commit
@pkozlowski-opensource
Copy link
Member Author

Note to self: most of the work is already done in #1415, we just need to pull individual commits and make sure that other remaining items are taken care of.

@alexnoise79
Copy link
Contributor

+1

1 similar comment
@mitulgolakiya
Copy link

+1

@FredLoney
Copy link

FredLoney commented Apr 14, 2017

A work-around for now is to specify the 4.0 packages in package.json, create npm-shrinkwrap.json with content similar to that below, rerun npm install and ignore the console <template> deprecation warning.

{
  "dependencies": {
    "@ng-bootstrap/ng-bootstrap": {
      "version": "1.0.0-alpha.23",
      "from": "node_modules/@ng-bootstrap/ng-bootstrap@1.0.0-alpha.23",
      "dependencies": {
        "@angular/core": {
          "version": "4.0.2",
          "from": "@angular/core@2.3.1"
        },
        "@angular/common": {
          "version": "4.0.2",
          "from": "@angular/common@2.3.1"
        },
        "@angular/forms": {
          "version": "4.0.2",
          "from": "@angular/forms@2.3.1"
        }
      }
    }
  }
}

@Serginho
Copy link

+1

1 similar comment
@seevee
Copy link

seevee commented Apr 19, 2017

+1

@mendeza
Copy link

mendeza commented Apr 21, 2017

My team runs with Angular 4, no problems.

@Serginho
Copy link

@mendeza Tabs component breaks on angular 4.

@pkozlowski-opensource
Copy link
Member Author

Just to be very clear: we do fully support Angular 4 today. This issue is only about switching our demo site and minimal peer dependency to Angular 4. It should have no noticeable impact on people using this project on Angular 4 already (apart from the removal of the warning for <template> tags). See more details in: #1337 (comment)

I'm going to lock this issue as it starts to accumulating noise without adding signal.

@Serginho if you see any problems with the latest release and Angular 4 please open a new issue following our issue template (plunker with a reproduce scenario is needed).

@ng-bootstrap ng-bootstrap locked and limited conversation to collaborators Apr 22, 2017
@pkozlowski-opensource
Copy link
Member Author

This one just fixed by 26bc8df - the alpha.25 release containing this fix will follow shortly.

cexbrayat pushed a commit to cexbrayat/ng-bootstrap that referenced this issue Dec 14, 2017
Closes ng-bootstrap#1337
Closes ng-bootstrap#1415
Closes ng-bootstrap#1433
Closes ng-bootstrap#1439

BREAKING CHANGE:

ng-bootstrap requires a minimal version of Angular 4.0.3

Closes ng-bootstrap#1512
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants