Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump up Angular dependency to 4.0.3 #1512

Closed
wants to merge 1 commit into from
Closed

feat: bump up Angular dependency to 4.0.3 #1512

wants to merge 1 commit into from

Conversation

pkozlowski-opensource
Copy link
Member

Closes #1337
Closes #1415
Closes #1433
Closes #1439

BREAKING CHANGE:

ng-bootstrap requires a minimal version of Angular 4.0.3

@pkozlowski-opensource
Copy link
Member Author

Let's wait a day or two to see if people don't report problems with the freshly released 1.0.0-alpha.24 and if not - let's get this one in!

Closes #1337
Closes #1415
Closes #1433
Closes #1439

BREAKING CHANGE:

ng-bootstrap requires a minimal version of Angular 4.0.3
@Danteisabck
Copy link

Danteisabck commented Apr 25, 2017

Hello @pkozlowski-opensource ,i'm using angular 4.0.3, i update ng-bootstrap to 1.0.0-alpha.24, but in build aot i have a same problem
Template parse warnings:
The element is deprecated. Use instead ("

[WARNING ->]<template ngFor let-panel [ngForOf]="panels"><div role="tab" id="{{panel.id}}-header""): ng:///D:/widget/web-widget/node_modules/@ng-bootstrap/ngbootstrap/accordion/accordion.d.ts.NgbAccordion.html@2:4

@pkozlowski-opensource
Copy link
Member Author

@Danteisabck of course, since this PR wasn't merged / released yet.... IT will be part of alpha.25. For now you can safely ignore the warning.

@Danteisabck
Copy link

@pkozlowski-opensource 1. can your tell when you are planning to merge this PR ?
2. And i have a silly question, if I use build aot i get this warnings but if i use build jit i don't get these warnings, i try to use carousel, can it be a problem with tsconfig aot ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants