Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ChangeDetectionStrategy.OnPush on ngbCarousel not working #2597

Closed
Jonas-Args opened this issue Aug 10, 2018 · 1 comment
Closed

ChangeDetectionStrategy.OnPush on ngbCarousel not working #2597

Jonas-Args opened this issue Aug 10, 2018 · 1 comment
Labels
component: carousel type: bug

Comments

@Jonas-Args
Copy link

when I implement ChangeDetectionStrategy.OnPush ngbcarousel doesn't work with atuomatic intervals
@pkozlowski-opensource
Copy link
Member

Confirmed, here is a reproduce scenario: https://stackblitz.com/edit/angular-uykamz?file=app/carousel-basic.ts

We should do markForCheck() when interval fires.

maxokorokov added a commit to maxokorokov/ng-bootstrap that referenced this issue Aug 13, 2018
@maxokorokov
fix(carousel): make it work inside the 'OnPush' components
26ea6e2 
Fixes ng-bootstrap#2597
@maxokorokov maxokorokov mentioned this issue Aug 13, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: carousel type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pkozlowski-opensource @Jonas-Args