Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ngb-rating swallows traps user keyboard navigation once focused #2895

Closed
peterblazejewicz opened this issue Dec 1, 2018 · 2 comments
Closed

ngb-rating swallows traps user keyboard navigation once focused #2895

peterblazejewicz opened this issue Dec 1, 2018 · 2 comments
Assignees
@maxokorokov
Labels
component: rating type: bug
Milestone
4.0.1

Comments

@peterblazejewicz
Copy link
Contributor

peterblazejewicz commented Dec 1, 2018 •
edited

Bug description:

Once ngbRating gets focused using keyboard navigation, it seems there is no reliable way to move focus to the next control and user navigation capabilities are lost - unless user clicks outside of the control to release focus

Link to minimally-working StackBlitz that reproduces the issue:

https://stackblitz.com/edit/angular-ng-rating-controls

  • click within app to allow keyboard navigation
  • move to Button via TAB so it gets focus outline
  • move focus via TAB to next controls: rating control
  • control gets focused
  • try to get focus to next control using TAB

Versions of Angular, ng-bootstrap and Bootstrap:

Angular: 7.0.*

ng-bootstrap: 4.0.0

Bootstrap: 4.1.*

Thanks!
@benouat
Copy link
Member

benouat commented Dec 3, 2018 •
edited

Thank you @peterblazejewicz for reporting this bug!

I am a bit amazed o_O it did not surfaced before... we will have a look at it asap.

EDIT: bug has been spotted. Fix will land asap 👍

@maxokorokov maxokorokov added this to the 4.0.1 milestone Dec 4, 2018
@maxokorokov maxokorokov self-assigned this Dec 4, 2018
maxokorokov added a commit to maxokorokov/ng-bootstrap that referenced this issue Dec 4, 2018
@maxokorokov
fix(rating): don't hijack Tab key navigation
f2b2c06 
Broken since ng-bootstrap#2473, we prevent default ALL known keys from Key enum

Fixes ng-bootstrap#2895
@maxokorokov maxokorokov mentioned this issue Dec 4, 2018
Merged
@maxokorokov
Copy link
Member

FYI, this seems to be broken since 2.2.0

maxokorokov added a commit to maxokorokov/ng-bootstrap that referenced this issue Dec 5, 2018
@maxokorokov
fix(rating): don't hijack Tab key navigation
c474cbb 
Broken since ng-bootstrap#2473, we prevent default ALL known keys from Key enum

Fixes ng-bootstrap#2895
maxokorokov added a commit that referenced this issue Dec 5, 2018
@maxokorokov
fix(rating): don't hijack Tab key navigation
4b05da1 
Broken since #2473, we prevent default ALL known keys from Key enum

Fixes #2895
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxokorokov maxokorokov

Labels
component: rating type: bug
Projects
None yet
Milestone
4.0.1
Development

No branches or pull requests
3 participants
@peterblazejewicz @benouat @maxokorokov