Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(util): make common the enum Key #2473

Closed
wants to merge 1 commit into from

Conversation

ymeine
Copy link
Contributor

@ymeine ymeine commented Jun 25, 2018

No description provided.

Copy link
Member

@maxokorokov maxokorokov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

maxokorokov added a commit to maxokorokov/ng-bootstrap that referenced this pull request Dec 4, 2018
Broken since ng-bootstrap#2473, we prevent default ALL known keys from Key enum

Fixes ng-bootstrap#2895
maxokorokov added a commit to maxokorokov/ng-bootstrap that referenced this pull request Dec 5, 2018
Broken since ng-bootstrap#2473, we prevent default ALL known keys from Key enum

Fixes ng-bootstrap#2895
maxokorokov added a commit that referenced this pull request Dec 5, 2018
Broken since #2473, we prevent default ALL known keys from Key enum

Fixes #2895
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants