Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Private APIs should not be used for the ng add schematic #3714

Closed
SchnWalter opened this issue May 2, 2020 · 2 comments · Fixed by #3802
Closed

Private APIs should not be used for the ng add schematic #3714

SchnWalter opened this issue May 2, 2020 · 2 comments · Fixed by #3802
Labels
needs: investigation type: schematics
Milestone
7.0.0

Comments

@SchnWalter
Copy link

Bug description:

The ng add schematic imports code from @schematics/angular/utility/project, which is a private file that will be removed in angular/angular-cli#17597

You can follow angular/angular#36897 and angular/components#19229, which provide fixes for similar issues with ng add @angular/localize and ng add @angular/cdk
@SchnWalter SchnWalter changed the title Update ng add schematic to not use private APIs Private APIs should not be used for the ng add schematic May 2, 2020
@maxokorokov maxokorokov added this to the 6.1.1 milestone May 3, 2020
@gpolychronis
Copy link
Contributor

@SchnWalter Where have you found that? Can you please provide which command have you executed so that ng-bootstrap uses from file @schematics/angular/utility/project ? Is there any file or log I can see this import?
Kind regards,

@SchnWalter
Copy link
Author

In the 2nd comment from the first link you'll find this:

https://github.com/ng-bootstrap/ng-bootstrap/blob/master/schematics/ng-add/index.ts#L8

It's the schematics for ng add, which is the fist command from the "Installation" section:

https://github.com/ng-bootstrap/ng-bootstrap#installation

@clydin clydin mentioned this issue Jun 26, 2020
Closed
15 tasks
@maxokorokov maxokorokov modified the milestones: 6.1.1, 7.0.0 Jun 29, 2020
alyahmedaly added a commit to alyahmedaly/ng-bootstrap that referenced this issue Jul 2, 2020
@alyahmedaly
refactor(schematics): update schematics to use new workspace API ng-b…
365986a 
…ootstrap#3714
alyahmedaly added a commit to alyahmedaly/ng-bootstrap that referenced this issue Jul 2, 2020
@alyahmedaly
refactor(schematics): update schematics to use new workspace API ng-b…
546a861 
…ootstrap#3714
@alyahmedaly alyahmedaly mentioned this issue Jul 2, 2020
Merged
alyahmedaly added a commit to alyahmedaly/ng-bootstrap that referenced this issue Jul 2, 2020
@alyahmedaly
refactor(schematics): update schematics to use new workspace API ng-b…
b5c8312 
…ootstrap#3714
alyahmedaly added a commit to alyahmedaly/ng-bootstrap that referenced this issue Jul 3, 2020
@alyahmedaly
refactor(schematics): update schematics to use new workspace API ng-b…
275d846 
…ootstrap#3714
alyahmedaly added a commit to alyahmedaly/ng-bootstrap that referenced this issue Jul 3, 2020
@alyahmedaly
refactor(schematics): update schematics to use new workspace API ng-b…
2a93440 
…ootstrap#3714
alyahmedaly added a commit to alyahmedaly/ng-bootstrap that referenced this issue Jul 3, 2020
@alyahmedaly
refactor(schematics): update schematics to use new workspace API ng-b…
031d708 
…ootstrap#3714
maxokorokov pushed a commit that referenced this issue Jul 6, 2020
@alyahmedaly @maxokorokov
refactor(schematics): update schematics to use new workspace API #3714
7c81d8d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs: investigation type: schematics
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

refactor(schematics): update schematics to use new workspace API #3714 alyahmedaly/ng-bootstrap
3 participants
@SchnWalter @maxokorokov @gpolychronis