Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Popover classlist gets fludded with extra classes related to placement on document scroll #4327

Closed
mis6ko13 opened this issue May 6, 2022 · 1 comment · Fixed by #4330
Closed

Popover classlist gets fludded with extra classes related to placement on document scroll #4327

mis6ko13 opened this issue May 6, 2022 · 1 comment · Fixed by #4330
Labels
type: bug type: positioning
Milestone
12.1.2

Comments

@mis6ko13
Copy link

mis6ko13 commented May 6, 2022

Bug description:

Popover (ngb-popover-window) classlist gets fludded with extra classes during document scrolling if one of the placement options contains '-start', '-left', '-end' or '-right' prefix.

Link to minimally-working StackBlitz that reproduces the issue:

https://stackblitz.com/edit/angular-qmskoz?file=src/app/popover-basic.html

Versions of Angular, ng-bootstrap and Bootstrap:

Angular: 13.0.3

ng-bootstrap: 12.1.1

Bootstrap: 5

image_2022_05_06T10_42_22_519Z
@fbasso
Copy link
Member

fbasso commented May 6, 2022

Thanks for reporting this issue @mis6ko13.

In your stackblitz, I was not able to find so many -end classes on the ngb-popover-window. But I can see a single one, which is already enough to reproduce it.

volvachev added a commit to volvachev/ng-bootstrap that referenced this issue May 12, 2022
@volvachev
fix(popover): not all classnames are removed after forceupdate
1a043df 
Fixed fluding popover classlist during updating with extra classes on document scroll

Fixes ng-bootstrap#4327.
@volvachev volvachev mentioned this issue May 12, 2022
Merged
@maxokorokov maxokorokov modified the milestones: 12.2.0, 12.1.2 May 16, 2022
maxokorokov pushed a commit to volvachev/ng-bootstrap that referenced this issue May 17, 2022
@volvachev @maxokorokov
fix(popover): not all classnames are removed after forceupdate
ba7e4d0 
Fixed fluding popover classlist during updating with extra classes on document scroll

Fixes ng-bootstrap#4327.
maxokorokov pushed a commit that referenced this issue May 17, 2022
@volvachev @maxokorokov
fix(popover): not all classnames are removed after forceupdate
9775246 
Fixed fluding popover classlist during updating with extra classes on document scroll

Fixes #4327.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug type: positioning
Projects
None yet
Milestone
12.1.2
Development

Successfully merging a pull request may close this issue.

fix(popover): not all classnames are removed after forceupdate volvachev/ng-bootstrap
3 participants
@fbasso @maxokorokov @mis6ko13