Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use angular 5.0.0 #1939

Closed
wants to merge 4 commits into from
Closed

chore: use angular 5.0.0 #1939

wants to merge 4 commits into from

Conversation

bastienmoulia
Copy link
Contributor

With the update to angular 5.0.0, other dependencies are updated:

@ngtools/webpack: 1.3.0 => 1.8.0
rxjs: ^5.0.1 => ^5.5.2
ts-loader: 2.0.0 => 3.1.1
typescript: 2.1.5 => 2.4.2

And I have to change AotPlugin by AngularCompilerPlugin following https://www.npmjs.com/package/@ngtools/webpack#usage

#1938
#1778

@bastienmoulia
Copy link
Contributor Author

TODO : Change new AngularCompilerPlugin() by new ngToolsWebpack.AngularCompilerPlugin()

https://github.com/angular/angular-cli/blob/2b982d2cba401b843579447063d20f0dd053b973/tests/e2e/assets/webpack/test-app-ng5/webpack.config.js

@bastienmoulia
Copy link
Contributor Author

Is that a memory error with Travis? Is it possible to relaunch the test?

@klozano
Copy link

klozano commented Nov 14, 2017

any news on this?

@yazshel
Copy link

yazshel commented Nov 15, 2017

yarn test passes fine on my system for this PR.ng-bootstrap is the only thing holding my project back from upgrading to Angular 5, so I for one would love to see this PR merged ASAP. So please relaunch the TravisCI tests...

@guillaume-ro-fr
Copy link

guillaume-ro-fr commented Nov 16, 2017

Hi @bastienmoulia

You need to close and reopen this PR to relaunch the Travis test according to this comment
: travis-ci/travis-ci#576 (comment) 😉

@bastienmoulia
Copy link
Contributor Author

@guillaume-ro-fr thanks I will do that !

@bastienmoulia
Copy link
Contributor Author

Error linked to angular/angular-cli#5618

@pkozlowski-opensource pkozlowski-opensource added this to the Angular 5 milestone Nov 17, 2017
@bastienmoulia
Copy link
Contributor Author

To recap, there are memory issues on the latest versions of the AOT compiler of angular, so I update to the latest versions of webpack and @ngtools/webpack for it to work well.

It is also advisable to use Node 8 LTS to further reduce memory but I have not made this change.

@pkozlowski-opensource
Copy link
Member

Thnx so much for this PR @bastienmoulia - much appreciated. Merged to master, will be released today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants