Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datepicker enhachment/5.1.0/event callback #3345

Conversation

gpolychronis
Copy link
Contributor

@gpolychronis gpolychronis commented Aug 30, 2019

Additional API to allow customization of Keydown event.

Rebased upon cc3b755.

@benouat Please review

@codecov-io
Copy link

Codecov Report

Merging #3345 into master will increase coverage by 2.73%.
The diff coverage is 54.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3345      +/-   ##
==========================================
+ Coverage   87.99%   90.72%   +2.73%     
==========================================
  Files          94       95       +1     
  Lines        2741     2750       +9     
  Branches      510      512       +2     
==========================================
+ Hits         2412     2495      +83     
+ Misses        268      193      -75     
- Partials       61       62       +1
Flag Coverage Δ
#e2e 54.94% <54.54%> (-45.06%) ⬇️
#unit 87.84% <54.54%> (-0.16%) ⬇️
Impacted Files Coverage Δ
src/datepicker/datepicker-input.ts 96.29% <50%> (+0.8%) ⬆️
src/datepicker/datepicker.ts 93.61% <55.55%> (-4.14%) ⬇️
src/index.ts 100% <0%> (ø)
src/tooltip/tooltip.ts 98.41% <0%> (+1.58%) ⬆️
src/util/positioning.ts 95.83% <0%> (+2.5%) ⬆️
src/popover/popover.ts 100% <0%> (+2.77%) ⬆️
src/util/util.ts 48.27% <0%> (+3.44%) ⬆️
src/typeahead/typeahead.ts 96.99% <0%> (+6.01%) ⬆️
src/util/accessibility/live.ts 95.83% <0%> (+12.5%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e26edc1...1091d5c. Read the comment docs.

@gpolychronis gpolychronis force-pushed the Datepicker-enhachment/5.1.0/event-callback branch from 1091d5c to 9f88f1d Compare September 3, 2019 08:03
Copy link
Member

@maxokorokov maxokorokov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I correct that we've decided not to implmement this change in favour of making keyboard mapping service public ?

@gpolychronis
Copy link
Contributor Author

Am I correct that we've decided not to implmement this change in favour of making keyboard mapping service public ?

Yes you are right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants