Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bs5 positioning classes (BREAKING CHANGE) #3963

Merged
merged 8 commits into from
Jan 26, 2021
Merged

Bs5 positioning classes (BREAKING CHANGE) #3963

merged 8 commits into from
Jan 26, 2021

Conversation

fbasso
Copy link
Member

@fbasso fbasso commented Jan 20, 2021 •
edited
Loading

Fixes the positioning in BS5 (without popper).

Related to the Bootstrap migration section : https://getbootstrap.com/docs/5.0/migration/#components

  • Positioning classes have been renamed (mainly left and right -> start and end)
  • Arrow classes have been renamed for popover and tooltip, to solve some positioning issues
  • Temporary missing classes have been added in demo\src\style\app.scss, as popper is not used yet in ngBootstrap
  • e2e tests will not pass as there other missing classes, impacting the layout

Breaking changes:

  • NgbSlideEventDirection : LEFT and RIGHT have been rename to START and END

@maxokorokov
Copy link
Member

@fbasso you should open it to the bootstrap5 branch

@maxokorokov maxokorokov added this to the 10.0.0 milestone Jan 20, 2021
@fbasso fbasso changed the base branch from master to bootstrap5 January 20, 2021 14:18
@fbasso
Copy link
Member Author

fbasso commented Jan 20, 2021

Thanks @maxokorokov, I did it.

@fbasso fbasso force-pushed the bs5-positioning-classes branch 2 times, most recently from 2696d69 to f898efb Compare January 20, 2021 15:16
@fbasso fbasso mentioned this pull request Jan 21, 2021
Closed
49 tasks
@fbasso fbasso changed the title Bs5 positioning classes Bs5 positioning classes (BREAKING CHANGE) Jan 21, 2021
@fbasso fbasso marked this pull request as ready for review January 26, 2021 10:25
@fbasso fbasso merged commit ed273ca into ng-bootstrap:bootstrap5 Jan 26, 2021
@fbasso fbasso deleted the bs5-positioning-classes branch January 26, 2021 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bootstrap 5 breaking change type: positioning
Projects
None yet
Milestone
12.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@fbasso @maxokorokov