Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: dropdownPosition=auto #237

Closed
pablomaurer opened this issue Feb 5, 2018 · 3 comments
Closed

feat: dropdownPosition=auto #237

pablomaurer opened this issue Feb 5, 2018 · 3 comments
Labels
good for contribution improvement

Comments

@pablomaurer
Copy link
Contributor

pablomaurer commented Feb 5, 2018 •
edited

I'm Migrating from angularjs to angular 5, there I used ui-select and they also had this needed feature.

[dropdownPosition]="'auto'"

The relevant code part is:
https://github.com/angular-ui/ui-select/blob/master/src/uiSelectDirective.js#L371

and here:
https://github.com/ng-select/ng-select/blob/master/src/ng-select/ng-select.component.ts#L499
@pablomaurer pablomaurer changed the title Feature: dropdownPosition]=auto Feature: dropdownPosition=auto Feb 5, 2018
@varnastadeus
Copy link
Member

@mnewmedia this could be good opportunity for you to contribute 😉

@pablomaurer pablomaurer changed the title Feature: dropdownPosition=auto feat: dropdownPosition=auto Feb 6, 2018
@pablomaurer pablomaurer mentioned this issue Feb 6, 2018
Merged
@pablomaurer
Copy link
Contributor Author

@varnastadeus I knew you would say that. 🤣
So here it is. 🎉

@anjmao
Copy link
Member

anjmao commented Feb 7, 2018

@mnewmedia Thanks for contributing, nice job, it works, but there are few issues, added some comments :)

anjmao pushed a commit that referenced this issue Feb 7, 2018
@pablomaurer @anjmao
feat: determine dropdownPosition automatically (#238)
d4404f7 
closes #237
@earshinov earshinov mentioned this issue Sep 7, 2018
Closed
jakemdunn pushed a commit to jakemdunn/ng-select that referenced this issue Oct 16, 2018
@pablomaurer @anjmao
feat: determine dropdownPosition automatically (ng-select#238)
4f77779 
closes ng-select#237
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good for contribution improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pablomaurer @anjmao @varnastadeus