Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label style fails #354

Closed
liwonder opened this issue Mar 15, 2018 · 4 comments
Closed

Label style fails #354

liwonder opened this issue Mar 15, 2018 · 4 comments
Labels

Comments

@liwonder
Copy link

liwonder commented Mar 15, 2018

Expected behaviour

screen shot 2018-03-15 at 10 15 03 am

Actual behaviour

screen shot 2018-03-15 at 10 11 23 am

More Info

We have a body element style set like this:
body { line-height: 1.3; font-size: 14px; }

Now I added a css below for a temporary fix:
ng-select .ng-value span { display: inline-block; }

And I am using:
@import "~@ng-select/ng-select/themes/default.theme.css";

ng-select version: [0.27.1]

browser: [ Chrome Version 65.0.3325.162 (Official Build) (64-bit)]

reproducible in demo page: [NO]

@liwonder
Copy link
Author

I also have a worked plunker here:
https://plnkr.co/edit/8bVrc1da11A2AebUrLZQ?p=preview

@bioub
Copy link
Contributor

bioub commented Mar 27, 2018

I have the same issue, incoming PR.

@anjmao
Copy link
Member

anjmao commented Mar 28, 2018

Hi @bioub I'm reopening this because fix with display: inline-block is breaking current style on demo page. On multiselect when item is selected dropdown becomes bigger.

@bioub
Copy link
Contributor

bioub commented Mar 28, 2018

I've removed some paddings to prevent this from happening, could you try with this PR ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants