Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(default.theme.scss) Disabled elements should have a margin left #406

Closed
bioub opened this issue Apr 2, 2018 · 2 comments
Closed

Comments

@bioub
Copy link
Contributor

bioub commented Apr 2, 2018

Expected behaviour

Disabled elements should have a margin left

capture d ecran 2018-04-02 a 14 05 11

Actual behaviour

Individual disabled elements don't have any margin left

capture d ecran 2018-04-02 a 14 05 26

More Info

ng-select version: 0.34.3

browser: all

reproducible in demo page: NO (don't have individual disabled elements)

I can't do the PR and stay compatible with #354 and existing code

@varnastadeus
Copy link
Member

Not sure if this issue still valid, on the demo page margins are present.
screen shot 2018-05-06 at 11 37 28

@bioub
Copy link
Contributor Author

bioub commented May 8, 2018

@varnastadeus It only affect individual disabled items (not the case on the demos page).

Check out this demo : https://angular-zkmecv.stackblitz.io/

jakemdunn pushed a commit to jakemdunn/ng-select that referenced this issue Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants