Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing option label doesn't update selected option label (regression from somwhere after 2.1.0) #980

Closed
devel112 opened this issue Dec 4, 2018 · 2 comments · Fixed by #982
Closed

Changing option label doesn't update selected option label (regression from somwhere after 2.1.0) #980

devel112 opened this issue Dec 4, 2018 · 2 comments · Fixed by #982
Assignees
@varnastadeus

Comments

@devel112
Copy link

devel112 commented Dec 4, 2018

Describe the bug
The selected value name doesn't update if the selected option names are changed. (This worked in 2.1.0).

Reproducbile example
Select Vilnius, then press Toggle name
Example 2.1.0 - works
Example 2.13.0

To Reproduce
Steps to reproduce the behavior

  1. Select Vilnius, then press Toggle name in the examples

Expected behavior
Also update the name of the selected value like in 2.1.0
@devel112
Copy link
Author

devel112 commented Dec 4, 2018

It works up untill 2.12.0 BTW
https://stackblitz.com/edit/ng-select-usrby2 - Working in 2.11.2

@varnastadeus
Copy link
Member

I will take a look, thanks

@varnastadeus varnastadeus self-assigned this Dec 4, 2018
varnastadeus added a commit that referenced this issue Dec 5, 2018
@varnastadeus
fix: map selected items while source changed
c5bfd3f 
closes #980, #977, #959
@varnastadeus varnastadeus mentioned this issue Dec 5, 2018
Merged
AndersTornkvist added a commit to AndersTornkvist/ng-select that referenced this issue Dec 31, 2018
@AndersTornkvist
Merge branch 'master'
af23c69 
* remotes/main/master: (25 commits)
  chore(release): 2.13.3
  fix: keep selected items while bindValue is incorrect closes ng-select#993
  chore(release): 2.13.2
  fix: appended dropdown position (ng-select#957)
  chore(release): 2.13.1
  fix: map selected items while source changed closes ng-select#980, ng-select#977, ng-select#959
  chore(release): 2.13.0
  [fix] - $event.path does not work in Safari and Firefox. Replace with $event.composedPath(). (ng-select#968)
  feat(templates): add searchTerm to header and footer (ng-select#961)
  chore(release): 2.12.1
  chore: include scss with package closes ng-select#909
  fix: use classList instead of className closes ng-select#940
  add aria-selected attribute on selected items (ng-select#936)
  fix: handler mousedown for clear event when used animation library (ng-select#931)
  chore(release): 2.12.0
  feat(autofocus): focus if attribute is present (ng-select#924)
  feat(isOpen): treat undefined value as default behaviour closes ng-select#816
  feat: allow to customise clear icon fixes ng-select#835
  chore(demo): fix virtual scroll example closes ng-select#921
  fix: keep items order while mapping selected options fixes ng-select#907
  ...
NickMele pushed a commit to NickMele/ng-select that referenced this issue Apr 12, 2019
@varnastadeus
fix: map selected items while source changed
8f180ba 
closes ng-select#980, ng-select#977, ng-select#959
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@varnastadeus varnastadeus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: map selected items while source changed ng-select/ng-select
2 participants
@varnastadeus @devel112