Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New property to make auto focus behavior more configurable #288

Merged
merged 2 commits into from
Oct 4, 2017

Conversation

igorrius
Copy link

Hello! Please see my PR. I had use a new property to make auto focus behavior more configurable. Thanks!

Igor Artasevych added 2 commits September 28, 2017 16:51
…ng. In this case the itemIndex was having a NaN value.
@igorrius igorrius mentioned this pull request Sep 29, 2017
@allenhwkim
Copy link
Contributor

I think we are having too many options.
Can you think other way without introducing a new option?

@igorrius
Copy link
Author

Maybe you are right, but many option gives us more flexible behavior. So, I promise will think about your propose. Thanks!)

@troolee
Copy link

troolee commented Sep 29, 2017

I don't thing this is a good solution. As for me, auto-focus should still work when user selects a value.

@igorrius
Copy link
Author

igorrius commented Oct 2, 2017

I don't thing this is a good solution. As for me, auto-focus should still work when user selects a value.

If you using two components in one form and you change focus between that, first component still be focused. Exactly this problem I was trying to fix.

@arthursp
Copy link

arthursp commented Oct 4, 2017

Could you please merge to master ? This feature is a requirement, as igorrius said, for example i am using it in ionic, and ionic allready set the focus on inputs ...

@allenhwkim allenhwkim merged commit 0e6dbc3 into ng2-ui:master Oct 4, 2017
@arthursp
Copy link

arthursp commented Oct 4, 2017

Could you also publish the npm module with a new version ?

@igorrius igorrius deleted the feature/focus-after-select branch October 4, 2017 14:44
@gilles-g
Copy link

Hi,
I think this is strange to have the attribute re-focus-after-select on true by default...now I need to pass on all my directives to add this attribute on false.
But thanks to propose a fix.

@matteobaldelli
Copy link

Why was it implemented only in directive and not in component??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants