Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nightly Regression #2415

Merged
merged 1 commit into from May 24, 2018
Merged

Nightly Regression #2415

merged 1 commit into from May 24, 2018

Conversation

bmarchant
Copy link
Contributor

Refs #2404
Removing more false assertions and protecting empty string references

@bmarchant bmarchant self-assigned this May 24, 2018
@bmarchant bmarchant requested a review from mschicker May 24, 2018 18:04
@bmarchant
Copy link
Contributor Author

@mschicker you know the drill. Thanks.

mschicker
mschicker approved these changes May 24, 2018
View reviewed changes
Copy link
Contributor

@mschicker mschicker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@bmarchant bmarchant merged commit 3c29c75 into develop May 24, 2018
@bmarchant bmarchant deleted the 2404_assert2 branch May 24, 2018 21:27
bwitham pushed a commit that referenced this pull request May 29, 2018
@bmarchant @bwitham
Removing more false assertions and protecting empty string references (…
ea20ed1 
…#2415)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mschicker mschicker mschicker approved these changes

Assignees

@bmarchant bmarchant

Labels
Category: Core Category: Test Priority: High Type: Bug Type: Maintenance Type: Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bmarchant @mschicker