-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3387 - Add option to diff conflate to keep reviews in output and more #3588
Conversation
…having all version equal to zero
…asnt recognizing diff properly
@curranMapper This change implements 2) from our discussion in #3387 about POIs being dropped during diff conflate. There's now an option, "Treat reviews as matches and remove from output", under the diff options in the UI (turned off by default) which will allow reviews to pass through to the diff output if desired. I opened #3579 as a longer term solution to make the POIs revews better. |
Thanks @bwitham will try this out in testing. |
differential.treat.reviews.as.matches
, that allows for not treating reviews as matches in Differential Conflation, which will let them pass to the diff output. The use case for this was a situation where a one to many POI review was preventing several secondary POIs from being added to the diff. Since some of these reviews were questionable, the longer term solution to this is some reworking of POI reviews (Improve the POI reviews from #3387 #3579). In the meantime, this config option may be useful.MapComparator::_printIdDiff
Roundabout
,OsmUtils
,Node
, andWay
that make debugging roundabout conflate problems easier