Unconnected way snapper investigation 4975 #5298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… requested. Updated unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
UnconnectedWaySnapperto the default pre or post conflate options in its current state mangles quite a few datasets. Generally the endpoints of two non-conflating ways are snapped together instead of remaining separate where they run in parallel. So it was added to some tests where it improved the output of the data. ('NonContiguousRoadReviewsTest' andNonDestructiveConflationTest) The snapper was also updated to not output the"hoot:snapped"="to_way_target"tag when not requested.Refs #4975