Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make download callback more defensive #5345

Merged
merged 2 commits into from
May 23, 2022
Merged

make download callback more defensive #5345

merged 2 commits into from
May 23, 2022

Conversation

maxgrossman
Copy link
Contributor

No description provided.

brianhatchl
brianhatchl approved these changes May 23, 2022
View reviewed changes
Copy link
Contributor

@brianhatchl brianhatchl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will fix the race condition if another download request clean up callback happens before this one.

@maxgrossman maxgrossman merged commit f3dcb2a into master May 23, 2022
@maxgrossman maxgrossman deleted the download_callback_bug_fix branch May 23, 2022 18:17
@maxgrossman maxgrossman restored the download_callback_bug_fix branch May 23, 2022 18:17
@maxgrossman maxgrossman deleted the download_callback_bug_fix branch May 23, 2022 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianhatchl brianhatchl brianhatchl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maxgrossman @brianhatchl