fix(source): fix mismatched return type #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmidtk
previously requested changes
Jan 10, 2018
src/os/data/columndefinition.js
Outdated
| @@ -1,6 +1,6 @@ | |||
| goog.provide('os.data.ColumnDefinition'); | |||
| goog.require('os.IPersistable'); | |||
| goog.require('os.parse.IColumnDefinition'); | |||
| goog.require('os.data.ColumnDefinition'); | |||
There was a problem hiding this comment.
Guessing this was from search/replace, but this file is now requiring itself.
src/os/data/columndefinition.js
Outdated
| @@ -27,9 +26,9 @@ os.data.ColumnDefinition = function(opt_name, opt_field) { | |||
|
|
|||
| /** | |||
| * The field | |||
| * @type {string} | |||
| * @type {!string} | |||
There was a problem hiding this comment.
! is implied for primitives. You also removed the || '', which would allow this value to be null/undefined if opt_name and opt_field aren't provided.
There was an inferred union type here {Array<!(ColumnDefinition\|FeatureTypeColumn)>} that the
compiler is not detecting as a mismatch with the declared type. I opened
google/closure-compiler#2783 with the compiler. This issue was causing
filters programmatically created from histogram bins to fail.
wallw-teal
force-pushed
the
fix-mismatched-return-type
branch
from
cb8ee79
to
2930aef
Compare
schmidtk
approved these changes
Jan 10, 2018
wallw-teal
pushed a commit
that referenced
this pull request
Feb 12, 2018
…rowser_button_to_browsercheck to master * commit '870fcbd4c7b85fc32274bde25b5731a44690ab49': feat(browser): Sync browser check between os and misc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an inferred union type here
{Array<!(ColumnDefinition\|FeatureTypeColumn)>}that the compiler is not detecting as a mismatch with the declared type. I opened google/closure-compiler#2783 with the compiler. This issue was causing filters programmatically created from histogram bins to fail.I also removed a superfluous, empty interface.