fix(kml): Replace the OpenLayers default icon with OpenSphere's. #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it be worth parameterising this in |
wallw-teal
approved these changes
Jul 22, 2019
|
@bradh this fixes a regression. If you want to write that up as an enhancement, that would be good. |
|
I agree with Will. That's a great idea, but the majority of places referencing the default icon are defined at the global scope. Changing that to a settings-driven value would require more of a refactor than I'm comfortable combining with this fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #676.
OpenLayers uses the yellow pushpin as the default icon style to match Google Earth's behavior. We prefer the placemark circle, so this replaces their defaults with ours.
To test, load this file. There should be a single point using the white placemark circle as the icon.
Note the KML node color varies because a
PolyStyleis defined in the KML, and that color is resolved when the node looks for a color in the style config. This is perhaps a bug since that color doesn't impact the rendered feature, but a separate issue if we want that behavior to change.