MQTT Fixes from Abstract #571
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I took a quick look and these changes are not compatible with paho mqtt client v2 and the MQTTv5 protocol. So this PR will probably only work for installs that are still using paho mqtt client v1. I will fix this when I have more time. |
|
It turned out to be an easy fix, see RichieB2B@69027ca and the paho migration documentation for reference. |
|
Incorporated -- thank you! |
|
Looks good, thanks @MikeBishop and @RichieB2B |
|
I tried this merged into my working branch (main + some PRs) and it seems to be working. Appreciate it if someone else can give it a try before we merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to pull out all the MQTT-related changes from #483, other than #492. This without #492 might be somewhat inconsistent.
Draft because I haven't explicitly tested this yet, just done the work in git to lift it out.