init peer #138
Merged
init peer #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coocood
reviewed
Mar 5, 2019
tikv/raftstore/peer.go
Outdated
| readyCnt int | ||
| } | ||
|
|
||
| func NewReadIndexQueue() *ReadIndexQueue { |
There was a problem hiding this comment.
We don't need this function, &ReadIndexQueue{} or new(ReadIndexQueue) will do.
tikv/raftstore/peer.go
Outdated
| queue []*ProposalMeta | ||
| } | ||
|
|
||
| func newProposalQueue() *ProposalQueue { |
There was a problem hiding this comment.
This function can be removed too.
tikv/raftstore/peer.go
Outdated
| } | ||
| } | ||
|
|
||
| func (q *ProposalQueue) Pop(term uint64) *ProposalMeta { |
tikv/raftstore/peer.go
Outdated
| WrittenKeys uint64 | ||
| } | ||
|
|
||
| func NewPeerStat() *PeerStat { |
tikv/raftstore/peer.go
Outdated
| PendingMergeApplyResult *WaitApplyResultStat | ||
| PeerStat *PeerStat | ||
|
|
||
| applyRouter router |
There was a problem hiding this comment.
This field is not present in TikV.
tikv/raftstore/peer.go
Outdated
| } | ||
|
|
||
| type Peer struct { | ||
| Cfg *Config |
There was a problem hiding this comment.
TiKV doesn't have this field.
tikv/raftstore/peer.go
Outdated
| Applied: appliedIndex, | ||
| CheckQuorum: true, | ||
| PreVote: cfg.Prevote, | ||
| Storage: ps, |
There was a problem hiding this comment.
Missing skip_bcast_commit?
There was a problem hiding this comment.
Will add it later, not this pr.
tikv/raftstore/peer.go
Outdated
| PeerHeartbeats: make(map[uint64]time.Time), | ||
| PeersStartPendingTime: make(map[uint64]time.Time), | ||
| RecentAddedPeer: NewRecentAddedPeer(uint64(cfg.RaftRejectTransferLeaderDuration.Seconds())), | ||
| SizeDiffHint: 0, |
There was a problem hiding this comment.
I think we can remove those zero value fields.
Signed-off-by: zhangjinpeng1987 <zhangjinpeng@pingcap.com>
Signed-off-by: zhangjinpeng1987 <zhangjinpeng@pingcap.com>
Signed-off-by: zhangjinpeng1987 <zhangjinpeng@pingcap.com>
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: zhangjinpeng1987 zhangjinpeng@pingcap.com