Refactor batch system #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Each peer can bind to a worker, and we can bind a peer to another worker if we need to. Currently, there is no scheduler to rebalance worker, simpler use the region id to bind a worker. |
ngaut
reviewed
Aug 9, 2019
tikv/raftstore/config.go
Outdated
| @@ -193,7 +193,7 @@ func NewDefaultConfig() *Config { | |||
| ApplyMaxBatchSize: 1024, | |||
| ApplyPoolSize: 2, | |||
| StoreMaxBatchSize: 1024, | |||
| StorePoolSize: 2, | |||
| StorePoolSize: 1, | |||
There was a problem hiding this comment.
For benchmark comparison, forgot to change it back, I will make it configurable.
bobotu
approved these changes
Aug 9, 2019
| } | ||
|
|
||
| func (pr *peerRouter) get(regionID uint64) *peerState { | ||
| pr.mu.RLock() |
There was a problem hiding this comment.
Using RWMutex in this scenario may cause some performance issue? 🤔
We can do some benchmark later.
ref: golang/go#17973
There was a problem hiding this comment.
We can shard the map based on the region ID for lower contention later.
There was a problem hiding this comment.
sync.Map or some kinds of COW map may also good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old batch system for multi-thread raft is too complex.
Replace it with a simpler multi-thread model.