Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug + fix in multimodules #34

Open
soywiz opened this issue Oct 23, 2017 · 1 comment
Open

Bug + fix in multimodules #34

soywiz opened this issue Oct 23, 2017 · 1 comment

Comments

@soywiz
Copy link

soywiz commented Oct 23, 2017

gradle-scalastyle-plugin/gradle-scalastyle-plugin_2.11/src/main/groovy/org/github/ngbinh/scalastyle/ScalaStyleTask.groovy

Line 77 in 0cea2e2

XmlOutput.save(config, outputFile, outputEncoding, messages)

You should change outputFile to project.file(outputFile)

Symptoms: empty xml file in submodule, actual xml file in root module or where CWD is
@soywiz
Copy link
Author

soywiz commented Oct 24, 2017

It reproduces with a custom relative outputFile

sch-cbavel added a commit to sch-cbavel/gradle-scalastyle-plugin that referenced this issue Oct 24, 2017
@sch-cbavel
XmlOutput.save should try to resolve outputFile inside project
867d506 
Fixes ngbinh#34
@sch-cbavel sch-cbavel mentioned this issue Oct 24, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@soywiz