Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use labels instead of environment variables #81

Closed
mariusGundersen opened this issue Apr 20, 2015 · 3 comments
Closed

Use labels instead of environment variables #81

mariusGundersen opened this issue Apr 20, 2015 · 3 comments

Comments

@mariusGundersen
Copy link

The latest version of docker let's you label a container with metadata, associating a string value to a string key. This seems like a better fit for VIRTUAL_HOST than using environment variables

@thaJeztah
Copy link
Contributor

I think both can make sense. One advantage of env is that they are accessible inside the container, which can be handy.

Nonetheless, adding support for labels could be nice :)

@md5
Copy link
Contributor

md5 commented May 4, 2015

I believe this can be closed now.

@jwilder
Copy link
Collaborator

jwilder commented May 4, 2015

Fixed by #82

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants