Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: Add proper entrypoint #531

Closed
wants to merge 1 commit into from

Commits on Jun 9, 2023

  1. docker: Add proper entrypoint

    As per docker guidelines [0] a container should always really have a
    consistent entrypoint, without having to override it or do special
    tricks.
    
    The behavior should be _identical_ as before, but will no longer trigger
    errors because docker-gen doesn't understand certain parameters (/bin/sh
    for example being common). Further more, allows a proper entrypoint for
    a CI to work easily with the container as well. Allowing for scenario's
    such as `apk add git && docker-gen renew` in a docker-gen image for example.
    
    E.g. `docker run docker-gen --help` works, as does `docker run
    docker-gen /bin/sh` or `docker run docker-gen ls`.
    
    [0]: https://github.com/docker-library/official-images#consistency
    
    Signed-off-by: Olliver Schinagl <oliver@schinagl.nl>
    oliv3r committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    b218c1c View commit details
    Browse the repository at this point in the history