Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix fastcgi bug #1116

Merged
merged 2 commits into from Sep 26, 2019
Merged

fix fastcgi bug #1116

merged 2 commits into from Sep 26, 2019

Conversation

qiqizjl
Copy link
Contributor

@qiqizjl qiqizjl commented Mar 30, 2018

fix fastcgi bug for debian

@controlcde
Copy link

I think you missed the same entry in the line 328.

@qiqizjl
Copy link
Contributor Author

qiqizjl commented Apr 17, 2018

@controlcde Thanks, Fixed

@gboor
Copy link

gboor commented May 16, 2018

Can this be merged? I see the checks fail, but I cannot really figure out why - everything seems to be in order. This would really help, as right now, fcgi support is completely broken for me and attempting to use a VIRTUAL_PROTO=fastcgi literally crashes the nginx-proxy container entirely.

@qiqizjl
Copy link
Contributor Author

qiqizjl commented May 17, 2018

@gboor Because fastcgi.conf is not included in the nginx image, fastcgi.conf is included in nginx:alpine.

@gboor
Copy link

gboor commented May 18, 2018

So the alpine version works?

If that is true, I think the Dockerfiles for Debian need to change so that another tmpl can be injected.

@qiqizjl
Copy link
Contributor Author

qiqizjl commented May 18, 2018

@gboor yes.alpine version is ok . If you want to use Debian, you can make corresponding changes based on the current PR. I think it can be normal operation.

@BlackSmith
Copy link

Hi folks,
any progress with this problem?

@G1K
Copy link

G1K commented Oct 4, 2018

very annoying bug. @jwilder accept the correction please
@qiqizjl look at the build errors please

@qiqizjl
Copy link
Contributor Author

qiqizjl commented Oct 8, 2018

@G1K Fixed in #1124

@SerikK
Copy link

SerikK commented Jun 25, 2019

@qiqizjl index.php not opening by default

@TheLastProject
Copy link

Any reason this hasn't been merged yet?

@jwilder
Copy link
Collaborator

jwilder commented Sep 26, 2019

@TheLastProject CI checks failed. I kicked them off again, but PR might need to be rebased.

@jwilder jwilder merged commit 4443ee8 into nginx-proxy:master Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants