Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agent can not handle "access_log off" in nginx configuration #184

Closed
defanator opened this issue Jan 27, 2023 · 1 comment · Fixed by #278
Closed

agent can not handle "access_log off" in nginx configuration #184

defanator opened this issue Jan 27, 2023 · 1 comment · Fixed by #278
Assignees
Labels
bug Something isn't working good-first-issue Good for newcomers

Comments

@defanator
Copy link
Contributor

If access_log off; is present in nginx configuration, agent treats the off part as a file name and throws the error:

time="2023-01-27T05:45:46Z" level=warning msg="NGINX Access log off is not readable or is disabled. Please make it readable and enabled in order for NGINX metrics to be collected."

The off is a special value that actually disables access log in a given block: https://nginx.org/en/docs/http/ngx_http_log_module.html#access_log

@Dean-Coakley Dean-Coakley added the bug Something isn't working label Jan 31, 2023
@Dean-Coakley
Copy link
Contributor

It makes sense to handle this case so that no warning is logged. Thanks for raising this issue @defanator

We'll fully investigate and fix shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good-first-issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants