Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handing of setting access_log off; #278

Merged
merged 3 commits into from
May 8, 2023

Conversation

Dean-Coakley
Copy link
Contributor

Proposed changes

Fixes: #184

  • Handle special value "off" for disabling access logging for a given context. No longer erroneously produces a warning.
  • Remove note in logs about disabled error_log. error_log off; does not disable error logging, this config produces an error_log in a file named off.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@netlify
Copy link

netlify bot commented Apr 5, 2023

Deploy Preview for agent-public-docs canceled.

Name Link
🔨 Latest commit 4466c5d
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/642d93327a77950008aef503

@github-actions github-actions bot added bug Something isn't working chore Pull requests for routine tasks dependencies labels Apr 5, 2023
@Dean-Coakley Dean-Coakley merged commit b12b293 into main May 8, 2023
@Dean-Coakley Dean-Coakley deleted the handle-disabled-accesslogs branch May 8, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chore Pull requests for routine tasks dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

agent can not handle "access_log off" in nginx configuration
5 participants