Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused nxt_vector_t API #1165

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Remove unused nxt_vector_t API #1165

merged 1 commit into from
Mar 5, 2024

Conversation

ac000
Copy link
Member

@ac000 ac000 commented Feb 29, 2024

This is unused, yet a community member just spent time finding and fixing a bug in it only to be told it's unused.

Just get rid of the thing.

@ac000 ac000 marked this pull request as ready for review March 5, 2024 05:56
@ac000 ac000 requested a review from hongzhidao March 5, 2024 05:57
@ac000
Copy link
Member Author

ac000 commented Mar 5, 2024

Rebased with master

$ git range-diff 69a75547...0345299e
-:  -------- > 1:  8ff606fb Configuration: Fix check in nxt_conf_json_parse_value()
1:  69a75547 = 2:  0345299e Remove unused nxt_vector_t API

@ac000
Remove unused nxt_vector_t API
4eb008b 
This is unused, yet a community member just spent time finding and
fixing a bug in it only to be told it's unused.

Just get rid of the thing.

Link: <nginx#963>
Reviewed-by: Zhidao Hong <z.hong@f5.com>
Signed-off-by: Andrew Clayton <a.clayton@nginx.com>
@ac000
Copy link
Member Author

ac000 commented Mar 5, 2024

Added Zhidao's Reviewed-by

$ git range-diff 0345299e...4eb008bb
1:  0345299e ! 1:  4eb008bb Remove unused nxt_vector_t API
    @@ Commit message
         Just get rid of the thing.
     
         Link: <https://github.com/nginx/unit/pull/963>
    +    Reviewed-by: Zhidao Hong <z.hong@f5.com>
         Signed-off-by: Andrew Clayton <a.clayton@nginx.com>
     
      ## auto/sources ##

@ac000 ac000 merged commit 4eb008b into nginx:master Mar 5, 2024
17 checks passed
@ac000 ac000 deleted the vec_remove branch March 5, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hongzhidao hongzhidao hongzhidao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ac000 @hongzhidao